NetworkDatabase impl with new ssv_types system#67
Merged
jking-aus merged 59 commits intosigp:unstablefrom Jan 9, 2025
Merged
Conversation
…er operations added, in memory construction
…n, move metadata insertion
Zacholme7
changed the title
ssv_types systemNetworkDatabase impl with new ssv_types system
… into clean-newtypes-database
Zacholme7
added
ready-for-review
jking-aus
approved these changes
Jan 9, 2025
Member
jking-aus
left a comment
jking-aus
left a comment
There was a problem hiding this comment.
great work here zac, happy with it based on our walkthrough review yesterday. Let's try and break these down a bit in future so we can merge faster and get more collaborative with the other guys. sick effort though
| /// Metadata about the validator this committee represents | ||
| pub validator_metadata: ValidatorMetadata, | ||
| /// Operators in this cluster | ||
| pub cluster_members: HashSet<OperatorId>, |
Member
There was a problem hiding this comment.
Should this be a Committee?
Member
Author
There was a problem hiding this comment.
I think committee is too broad of a term here. A committee just refers to a general set of operators while here the cluster_members are meant to be the direct members of the cluster. Its trying to enforce the relationship. But, there is also an argument that committee is also applicable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
This PR introduces
a newassv_typessystem and associatedNetworkDatabase.Edit: New
ssv_typessplit into #69The
NetworkDatabaseportion of this PR is a MVP of the database which holds all of the types information above. The database is just simple CRUD with in memory stores for relevant information. It will store all of the information during execution event sync and turn it into in memory stores that we deem relevant. These stores will be recreated via the DB upon node restart.