feat: add panic hook for logging#674
Merged
mergify[bot] merged 1 commit intosigp:release-v1.0.0from Oct 10, 2025
Merged
Conversation
dknopik
added
ready-for-review
jking-aus
added
ready-for-merge
and removed
ready-for-review
17 tasks
petarjuki7
pushed a commit
to petarjuki7/anchor
that referenced
this pull request
Oct 16, 2025
When going through LH's and Anchor's startup procedures, I noticed that Anchor does not have a panic hook, causing panics to only be printed on stderr, but not in logs. This is bad in cases where the user only retains logs, but not stderr. Steal panic hook code from LH, logging the panic properly. Co-Authored-By: Daniel Knopik <daniel@dknopik.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
When going through LH's and Anchor's startup procedures, I noticed that Anchor does not have a panic hook, causing panics to only be printed on stderr, but not in logs. This is bad in cases where the user only retains logs, but not stderr.
Proposed Changes
Steal panic hook code from LH, logging the panic properly.