Replace warp_utils with health_metrics #82
Closed
ThreeHrSleep wants to merge 2 commits intosigp:unstablefrom
Closed
Replace warp_utils with health_metrics #82ThreeHrSleep wants to merge 2 commits intosigp:unstablefrom
warp_utils with health_metrics #82ThreeHrSleep wants to merge 2 commits intosigp:unstablefrom
Conversation
Member
|
all good -- changes include in PR #86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
use
scrape_health_metricsfromhealth_metricsinstead ofwarp_utils.Additional Info
this should help us avoid unnecessarily pulling
beacon_chaincurrently using this branch for
health_metrics. will have to wait tilldependency-cleanupchanges get merged in lighthouse.