Ensure the "workspace.dependencies" table is sorted#97
Merged
jking-aus merged 2 commits intosigp:unstablefrom Jan 16, 2025
Merged
Ensure the "workspace.dependencies" table is sorted#97jking-aus merged 2 commits intosigp:unstablefrom
jking-aus merged 2 commits intosigp:unstablefrom
Conversation
also, sort the dependencies
dknopik
added
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
cargo sortdoes not sort the workspace dependencies #88Proposed Changes
As a workaround, use Taplo to check during CI whether the dependencies are sorted.
Additional Info
Taplo allows empty lines for different sorted subsections, so I categorized the dependencies: Anchor internal, Lighthouse dependencies, other dependencies
Yes, this is annoying, but it ensures easy and clean merges once we are all on the same page.