Migrate validator client to clap derive by eserilev · Pull Request #6300 · sigp/lighthouse

eserilev · 2024-08-23T01:27:04Z

Issue Addressed

Partially #5900

Proposed Changes

Migrate the validator client cli to clap derive

eserilev · 2024-08-23T02:07:07Z

validator_client/src/config.rs

+        if validator_client_config.web3_signer_keep_alive_timeout == 0 {
+            config.web3_signer_keep_alive_timeout = None
+        } else {
+            config.web3_signer_keep_alive_timeout = Some(Duration::from_millis(
+                validator_client_config.web3_signer_keep_alive_timeout,
+            ));


Note the breaking change here. Since I've defined web3_signer_keep_alive_timeout as a u64, null is no longer a valid option. Users will need to use 0 instead.

If this breaking change is too intrusive I can define web3_signer_keep_alive_timeout as a string and we can keep functionality as is.

I think this is probably ok, not sure if anyone actually remove the web3signer timeout? (cc @michaelsproul)
I've added backwards-incompat label.

Yeah this is probably obscure enough that we would be OK to change it. It's a bit dodgy because it flips the meaning of 0 from "timeout immediately" to "never timeout", but I doubt anyone is using 0

…ap-derive-validator-manager

michaelsproul · 2024-11-07T22:20:12Z

Maybe we should merge this PR first, as it will conflict:

Split the VC into crates making it more modular #6453

michaelsproul · 2024-11-08T01:05:17Z

Age's PR is merged now. Some conflicts to resolve and then we can merge this.

…ap-derive-validator-manager

eserilev · 2024-11-22T17:43:12Z

merge conflicts have been resolved

macladson

LGTM!

…ap-derive-validator-manager

dapplion

All flags match to current unstable

mergify · 2025-01-25T09:39:55Z

This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏

mergify · 2025-02-03T07:38:51Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

☑️ test-suite-success

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Redo this PR: - #5480 After a regression during the switch to `clap_derive`. - #6300 - Remove `conflicts_with` - Add test to prevent future regression

eserilev added 3 commits August 19, 2024 13:29

add derive cli definitions

4513851

update

bea2b48

change cli

3768588

eserilev changed the title ~~Migrate validator manager to clap derive~~ Migrate validator client to clap derive Aug 23, 2024

fix test

1e19018

eserilev commented Aug 23, 2024

View reviewed changes

cli docs

1a9ad30

eserilev added the code-quality label Aug 23, 2024

eserilev mentioned this pull request Aug 23, 2024

Implement Clap derive #5900

Open

8 tasks

fmt

a80452b

eserilev marked this pull request as ready for review August 23, 2024 02:50

eserilev added the ready-for-review The code is ready for review label Aug 23, 2024

fix lint issue

99007eb

eserilev added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Aug 23, 2024

eserilev added 10 commits August 26, 2024 11:24

fix flag name

5f4bf78

fix cli

a944744

Merge branch 'unstable' of https://github.com/sigp/lighthouse into cl…

9e7bed2

…ap-derive-validator-manager

reintroduce deprecated flag

49da4e9

fix test

e8b7996

cli fix

d986f84

fix test

c90d977

fix another test

5e96273

Merge branch 'unstable' of https://github.com/sigp/lighthouse into cl…

e98f0d9

…ap-derive-validator-manager

fix test

461cc22

eserilev added ready-for-review The code is ready for review work-in-progress PR is a work-in-progress and removed work-in-progress PR is a work-in-progress ready-for-review The code is ready for review labels Sep 3, 2024

fix test

4344953

michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Nov 8, 2024

eserilev added 3 commits November 8, 2024 10:30

resolve merge conflicts

74ce49b

fix test

28fa46b

Merge branch 'unstable' of https://github.com/sigp/lighthouse into cl…

2b21122

…ap-derive-validator-manager

eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 22, 2024

macladson approved these changes Nov 28, 2024

View reviewed changes

jxs mentioned this pull request Dec 18, 2024

Add discv5 sigp/anchor#72

Merged

resolve merge conflicts

71eed11

eserilev added the v7.0.0-beta.0 New release c. Q1 2025 label Jan 16, 2025

eserilev added 4 commits January 16, 2025 15:01

run make cli

9620ff1

Cargo sort

0d56112

Merge branch 'unstable' of https://github.com/sigp/lighthouse into cl…

f615817

…ap-derive-validator-manager

FMT strikes again

9eca0e6

dapplion approved these changes Jan 25, 2025

View reviewed changes

resolve conflicts

9619994

jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 3, 2025

mergify bot added a commit that referenced this pull request Feb 3, 2025

Merge of #6300

b2f8192

mergify bot mentioned this pull request Feb 3, 2025

merge queue: embarking unstable (95cec45) and #6300 together #6904

Closed

6 tasks

Merge branch 'unstable' into clap-derive-validator-manager

0fa70ff

mergify bot merged commit 7e4b27c into sigp:unstable Feb 3, 2025
32 checks passed

michaelsproul mentioned this pull request Apr 6, 2025

Remove CLI conflict for secrets-dir and datadir #7265

Merged

mergify bot pushed a commit that referenced this pull request Apr 6, 2025

Remove CLI conflict for secrets-dir and datadir (#7265)

e77fb01

Redo this PR: - #5480 After a regression during the switch to `clap_derive`. - #6300 - Remove `conflicts_with` - Add test to prevent future regression

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Migrate validator client to clap derive#6300

Migrate validator client to clap derive#6300
mergify[bot] merged 53 commits intosigp:unstablefrom
eserilev:clap-derive-validator-manager

eserilev commented Aug 23, 2024 •

edited

Loading

Uh oh!

eserilev Aug 23, 2024 •

edited

Loading

Uh oh!

jimmygchen Nov 5, 2024

Uh oh!

michaelsproul Nov 8, 2024

Uh oh!

michaelsproul commented Nov 7, 2024

Uh oh!

michaelsproul commented Nov 8, 2024

Uh oh!

eserilev commented Nov 22, 2024

Uh oh!

macladson left a comment

Uh oh!

dapplion left a comment

Uh oh!

mergify bot commented Jan 25, 2025

Uh oh!

mergify bot commented Feb 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

eserilev commented Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Addressed

Proposed Changes

Uh oh!

eserilev Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jimmygchen Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

michaelsproul Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

michaelsproul commented Nov 7, 2024

Uh oh!

michaelsproul commented Nov 8, 2024

Uh oh!

eserilev commented Nov 22, 2024

Uh oh!

macladson left a comment

Choose a reason for hiding this comment

Uh oh!

dapplion left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jan 25, 2025

Uh oh!

mergify bot commented Feb 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eserilev commented Aug 23, 2024 •

edited

Loading

eserilev Aug 23, 2024 •

edited

Loading