Attempt at reproducible builds#6394
Closed
michaelsproul wants to merge 9 commits intosigp:unstablefrom
Closed
Conversation
Member
Author
|
Dropping this from v6.0.0. No bandwidth to work on it at the moment. |
Closed
Member
Author
|
Closing in favour of a more comprehensive PR from Flashbots: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes:
Proposed Changes
make reproducible. This is tested and working on Linux x86_64 and macOS aarch64.crossbuilds to build in a reproducible way by default.lighthouse --version.The key insight is setting
SOURCE_DATE_EPOCHso OpenSSL doesn't include the build time in the binary. Thanks @jmcph4 for helping work this out.Limitations
There is no reproducibility between builds outside
crossand builds withincross. The binary diff is large and I haven't worked out what it could be (yet). It might be due to differentlibcversions.