SingleAttestation full implementation#6616
Closed
eserilev wants to merge 12 commits intosigp:unstablefrom
Closed
Conversation
…ngle_attestation_electra
eserilev
added
blocked
work-in-progress
3 tasks
michaelsproul
changed the title
SingleAttestation refactorSingleAttestation full implementation
This was referenced Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #6380
This is the "full" implementation of the new
SingleAttestationchanges. Theres probably no need to merge this in before Electra assuming that #6488 is sufficient for making us fully spec compliantThis also implements the new submit attestation v2 endpoint ethereum/beacon-APIs#472
We'll also want to eventually want to yank out all the unaggregated attestation logic so that both the
GossipAttestationandGossipSingleAttestationflows are unified. I might handle that in this PR, or in a subsequent PR depending on feedback from the rest of the team.