Allow importing of historical blobs via HTTP API#6656
Open
macladson wants to merge 13 commits intosigp:unstablefrom
Open
Allow importing of historical blobs via HTTP API#6656macladson wants to merge 13 commits intosigp:unstablefrom
macladson wants to merge 13 commits intosigp:unstablefrom
Conversation
macladson
force-pushed
the
import-blobs-api
branch
from
cda4d20 to
cc6bb00
Compare
|
This pull request has merge conflicts. Could you please resolve them @macladson? 🙏 |
| } | ||
|
|
||
| // Check if a `blob_sidecar_list` is already stored for this block root. | ||
| match self.get_blobs(&block_root) { |
Member
There was a problem hiding this comment.
Lets try adding a log with the time that this step takes
|
This pull request has merge conflicts. Could you please resolve them @macladson? 🙏 |
mergify
bot
added
the
waiting-on-author
macladson
force-pushed
the
import-blobs-api
branch
from
6fd11d9 to
7d1ae6e
Compare
macladson
removed
the
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5391
Proposed Changes
Allows importing historical blobs into the blobs-db via the
/lighthouse/database/import_blobsendpoint.Supports SSZ through
/lighthouse/database/import_blobs_ssz.In both cases, the required format must deserialize to
Vec<BlobSidecarList<E>>Performs the following checks:
block_rootis consistent across eachBlobSidecarList.block_rootexists in the database.BlobSidecarListis already stored for thatblock_root. If it is, ensure it matches theBlobSidecarListwe are attempting to store.