Skip to content

merge queue: embarking unstable (f51a292) and [#6762 + #6537] together #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mergify wants to merge 8 commits into from
Closed

merge queue: embarking unstable (f51a292) and [#6762 + #6537] together #6763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5ef17e9
Add 'beacon_' prefix to PeerDAS metrics names
KatyaRyazantseva Oct 23, 2024
abbf3ee
Merge remote-tracking branch 'origin/unstable' into peerdas-metrics
KatyaRyazantseva Nov 4, 2024
19c61f9
Merge 'origin/unstable' into peerdas-metrics
KatyaRyazantseva Nov 9, 2024
1c92387
Merge remote-tracking branch 'origin/unstable/ into peerdas-metrics
KatyaRyazantseva Dec 20, 2024
b4def7b
Add 'beacon_' prefix to 'kzg_data_column' metrics
KatyaRyazantseva Dec 20, 2024
93f1104
add joao CODEOWNERS
realbigsean Jan 7, 2025
2704559
Merge of #6762
mergify[bot] Jan 7, 2025
7e4279e
Merge of #6537
mergify[bot] Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
beacon_node/network/ @jxs
beacon_node/lighthouse_network/ @jxs
18 changes: 9 additions & 9 deletions beacon_node/beacon_chain/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1656,7 +1656,7 @@ pub static BLOB_SIDECAR_INCLUSION_PROOF_COMPUTATION: LazyLock<Result<Histogram>>
});
pub static DATA_COLUMN_SIDECAR_COMPUTATION: LazyLock<Result<HistogramVec>> = LazyLock::new(|| {
try_create_histogram_vec_with_buckets(
"data_column_sidecar_computation_seconds",
"beacon_data_column_sidecar_computation_seconds",
"Time taken to compute data column sidecar, including cells, proofs and inclusion proof",
Ok(vec![0.1, 0.15, 0.25, 0.35, 0.5, 0.7, 1.0, 2.5, 5.0, 10.0]),
&["blob_count"],
Expand All @@ -1665,7 +1665,7 @@ pub static DATA_COLUMN_SIDECAR_COMPUTATION: LazyLock<Result<HistogramVec>> = Laz
pub static DATA_COLUMN_SIDECAR_INCLUSION_PROOF_VERIFICATION: LazyLock<Result<Histogram>> =
LazyLock::new(|| {
try_create_histogram(
"data_column_sidecar_inclusion_proof_verification_seconds",
"beacon_data_column_sidecar_inclusion_proof_verification_seconds",
"Time taken to verify data_column sidecar inclusion proof",
)
});
Expand Down Expand Up @@ -1847,7 +1847,7 @@ pub static KZG_VERIFICATION_BATCH_TIMES: LazyLock<Result<Histogram>> = LazyLock:
pub static KZG_VERIFICATION_DATA_COLUMN_SINGLE_TIMES: LazyLock<Result<Histogram>> =
LazyLock::new(|| {
try_create_histogram_with_buckets(
"kzg_verification_data_column_single_seconds",
"beacon_kzg_verification_data_column_single_seconds",
"Runtime of single data column kzg verification",
Ok(vec![
0.0005, 0.001, 0.0015, 0.002, 0.003, 0.004, 0.005, 0.007, 0.01, 0.02, 0.05,
Expand All @@ -1857,7 +1857,7 @@ pub static KZG_VERIFICATION_DATA_COLUMN_SINGLE_TIMES: LazyLock<Result<Histogram>
pub static KZG_VERIFICATION_DATA_COLUMN_BATCH_TIMES: LazyLock<Result<Histogram>> =
LazyLock::new(|| {
try_create_histogram_with_buckets(
"kzg_verification_data_column_batch_seconds",
"beacon_kzg_verification_data_column_batch_seconds",
"Runtime of batched data column kzg verification",
Ok(vec![
0.002, 0.004, 0.006, 0.008, 0.01, 0.012, 0.015, 0.02, 0.03, 0.05, 0.07,
Expand Down Expand Up @@ -1910,38 +1910,38 @@ pub static DATA_AVAILABILITY_OVERFLOW_STORE_CACHE_SIZE: LazyLock<Result<IntGauge
pub static DATA_AVAILABILITY_RECONSTRUCTION_TIME: LazyLock<Result<Histogram>> =
LazyLock::new(|| {
try_create_histogram(
"data_availability_reconstruction_time_seconds",
"beacon_data_availability_reconstruction_time_seconds",
"Time taken to reconstruct columns",
)
});
pub static DATA_AVAILABILITY_RECONSTRUCTED_COLUMNS: LazyLock<Result<IntCounter>> =
LazyLock::new(|| {
try_create_int_counter(
"data_availability_reconstructed_columns_total",
"beacon_data_availability_reconstructed_columns_total",
"Total count of reconstructed columns",
)
});

pub static KZG_DATA_COLUMN_RECONSTRUCTION_ATTEMPTS: LazyLock<Result<IntCounter>> =
LazyLock::new(|| {
try_create_int_counter(
"kzg_data_column_reconstruction_attempts",
"beacon_kzg_data_column_reconstruction_attempts",
"Count of times data column reconstruction has been attempted",
)
});

pub static KZG_DATA_COLUMN_RECONSTRUCTION_FAILURES: LazyLock<Result<IntCounter>> =
LazyLock::new(|| {
try_create_int_counter(
"kzg_data_column_reconstruction_failures",
"beacon_kzg_data_column_reconstruction_failures",
"Count of times data column reconstruction has failed",
)
});

pub static KZG_DATA_COLUMN_RECONSTRUCTION_INCOMPLETE_TOTAL: LazyLock<Result<IntCounterVec>> =
LazyLock::new(|| {
try_create_int_counter_vec(
"kzg_data_column_reconstruction_incomplete_total",
"beacon_kzg_data_column_reconstruction_incomplete_total",
"Count of times data column reconstruction attempts did not result in an import",
&["reason"],
)
Expand Down
Loading