Add libssl install to udeps task#6777
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Jan 10, 2025
Merged
Conversation
jimmygchen
approved these changes
Jan 9, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Thanks for looking into this 🙏
I don't mind merging this to unblock CI!
I think our options are:
- install libssl 1.1 on the runner (this PR)
- revert to
ubuntu-22.04- this is probably not a long term solution either - investigate possibility of removing ssl 1.1 dependency complelely (likely from reqwest?)
michaelsproul
approved these changes
Jan 9, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Agree we should just merge this to unblock CI, and then hope that cargo-udeps is updated so as not to require this.
jimmygchen
added
ready-for-merge
Merged
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at a244aa3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not really sure what happened between now and yesterday, but I do know libssl1.1 has reached EOL recently. The udeps ci task wants to access libssl1.1 for some reason, so I've added a step to install it. It's not the cleanest fix, if anyone has better ideas please let me know
Here's the original error message
error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directoryAnd some informational links
https://stackoverflow.com/questions/72133316/libssl-so-1-1-cannot-open-shared-object-file-no-such-file-or-directory
https://openssl-library.org/post/2023-03-28-1.1.1-eol/