Skip to content

Comments

Use existing peer count metrics loop to check for open_nat toggle #6800

Merged
mergify[bot] merged 10 commits intosigp:unstablefrom
jking-aus:libp2p_nat_detection
Jan 15, 2025
Merged

Use existing peer count metrics loop to check for open_nat toggle #6800
mergify[bot] merged 10 commits intosigp:unstablefrom
jking-aus:libp2p_nat_detection

Conversation

@jking-aus
Copy link
Member

@jking-aus jking-aus commented Jan 13, 2025 •
edited
Loading

Issue Addressed

This addresses issue #6683

Proposed Changes

  • Add helper functions to peerinfo to get ip4 and ip6 inbound connections
  • Add threshold of 3 connections to determine if NAT is open to peer manager
  • Add update nat_open function when updating peer_count_metrics

@jking-aus jking-aus requested a review from AgeManning January 13, 2025 22:32
@jking-aus jking-aus changed the title Use peerdb to determine if libp2p nat_open metric should be toggled Use existing peer count metrics loop to check for open_nat toggle Jan 14, 2025
@jking-aus jking-aus marked this pull request as ready for review January 14, 2025 04:30
@jking-aus jking-aus requested a review from jxs as a code owner January 14, 2025 04:30
AgeManning
AgeManning approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@AgeManning
Copy link
Member

AgeManning commented Jan 15, 2025

@mergify queue

@mergify
Copy link

mergify bot commented Jan 15, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 4fd8e52

mergify bot added a commit that referenced this pull request Jan 15, 2025
@mergify
Merge of #6800
326e893
@mergify mergify bot mentioned this pull request Jan 15, 2025
Closed
5 tasks
@mergify mergify bot merged commit 4fd8e52 into sigp:unstable Jan 15, 2025
29 checks passed
@jimmygchen jimmygchen mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AgeManning AgeManning AgeManning approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jking-aus @AgeManning