Skip to content

Comments

Execution requests with prefix#6801

Merged
mergify[bot] merged 3 commits intosigp:unstablefrom
pawanjay176:empty-requests
Jan 14, 2025
Merged

Execution requests with prefix#6801
mergify[bot] merged 3 commits intosigp:unstablefrom
pawanjay176:empty-requests

Conversation

@pawanjay176
Copy link
Member

Issue Addressed

Addresses ethereum/consensus-specs#3998 . Making a new PR because #6752 got closed

Proposed Changes

Make engine api alpha 10 spec compliant. Tested this on kurtosis with a geth client and confirms it works for single requests, gonna add tests for invalid requests in a separate PR in the spirit of getting devnet 5 ready asap.

@pawanjay176 pawanjay176 added ready-for-review The code is ready for review electra-alpha10 Electra release for devnet 5 labels Jan 13, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge to unstable!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 14, 2025
@michaelsproul
Copy link
Member

Just re-running the local testnet jobs which I think failed due to the Github outage

@michaelsproul
Copy link
Member

@mergify queue

@mergify
Copy link

mergify bot commented Jan 14, 2025

queue

🛑 The pull request has been removed from the queue default

Details

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul michaelsproul mentioned this pull request Jan 14, 2025
2 tasks
@mergify
Copy link

mergify bot commented Jan 14, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@michaelsproul
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Jan 14, 2025

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Jan 14, 2025

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 93f9c2c

@mergify mergify bot merged commit 93f9c2c into sigp:unstable Jan 14, 2025
30 checks passed
@michaelsproul
Copy link
Member

heck yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

electra-alpha10 Electra release for devnet 5 ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants