Do not send column requests if there is no blob for the block.#6814
Merged
mergify[bot] merged 3 commits intosigp:unstablefrom Jan 20, 2025
Merged
Conversation
jimmygchen
added
bug
dapplion
reviewed
Jan 17, 2025
jimmygchen
added
waiting-on-author
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Jan 17, 2025
) Squashed commit of the following: commit 884ba44 Author: Jimmy Chen <jchen.tc@gmail.com> Date: Fri Jan 17 16:13:28 2025 +1100 Do not send column requests if there is no blob for the block.
dapplion
approved these changes
Jan 20, 2025
jimmygchen
added
ready-for-merge
jimmygchen
added
ready-for-merge
Member
Author
|
Just found that the previous solution didn't actually work because we don't pass the blob count to I realise the we actually have |
jimmygchen
force-pushed
the
do-not-send-custody-request-no-blobs
branch
from
aad2a8e to
085197d
Compare
dapplion
approved these changes
Jan 20, 2025
Collaborator
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
Nice find! Better solution
jimmygchen
added
ready-for-merge
Member
Author
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 6ce33c4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
We currently send custody column requests to peers even on blocks that do not contain any blobs. This is unnecessary and is removed in this PR.