Skip to content

Comments

POST /eth/v2/beacon/pool/attestations bugfixes#6867

Merged
mergify[bot] merged 12 commits intosigp:unstablefrom
eserilev:post-attestations-v2-bugfixes
Jan 31, 2025
Merged

POST /eth/v2/beacon/pool/attestations bugfixes#6867
mergify[bot] merged 12 commits intosigp:unstablefrom
eserilev:post-attestations-v2-bugfixes

Conversation

@eserilev
Copy link
Member

@eserilev eserilev commented Jan 26, 2025

Closes #6857

  • The v2 endpoint can now accept both SingleAttestation and pre-Electra Attestation
  • SingleAttestation fields committee_index and attester_index now accept strings when deserializing from JSON

@eserilev
Fix v2 endpoint to allow for both SingleAttestation and pre-electra A…
f9ba8dc 
…ttestation, and accept strings for committee_index and attester_index fields
@eserilev eserilev added bug Something isn't working ready-for-review The code is ready for review HTTP-API electra Required for the Electra/Prague fork v7.0.0-beta.0 New release c. Q1 2025 labels Jan 26, 2025
@eserilev eserilev requested a review from jxs as a code owner January 26, 2025 15:21
@eserilev eserilev added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Jan 27, 2025
@eserilev eserilev added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jan 27, 2025
michaelsproul
michaelsproul reviewed Jan 28, 2025
View reviewed changes
michaelsproul
michaelsproul reviewed Jan 28, 2025
View reviewed changes
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 28, 2025
@michaelsproul michaelsproul mentioned this pull request Jan 28, 2025
Closed
2 tasks
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 29, 2025
michaelsproul
michaelsproul requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggested change

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 30, 2025
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 30, 2025
@mergify mergify bot merged commit 276eda3 into sigp:unstable Jan 31, 2025
31 checks passed
@eserilev eserilev mentioned this pull request Feb 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees

No one assigned

Labels

bug Something isn't working electra Required for the Electra/Prague fork HTTP-API ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eserilev @michaelsproul