Implement selections Beacon API endpoints to support DVT middleware#7016
Implement selections Beacon API endpoints to support DVT middleware#7016mergify[bot] merged 89 commits intosigp:unstablefrom
selections Beacon API endpoints to support DVT middleware#7016Conversation
selections API endpoints to support DVT middlewareselections Beacon API endpoints to support DVT middleware
|
With the commit 8b2f058 where VC sends partial signatures in parallel for all validators for a slot, I believe the aggregated attestations are successful (during testing) now, thank you @michaelsproul ! Lighthouse VC logs: for every slot now Charon logs: for every slot now too @KaloyanTanev could you give it a try and confirm that the beacon committee selection endpoint is working as intended? Thanks |
|
I am still confused about the |
|
Some required checks have failed. Could you please take a look @chong-he? 🙏 |
dknopik
left a comment
There was a problem hiding this comment.
Now that the off-by-one is fixed, this is good to go from an Anchor point of view :)
Thank you @chong-he!
@michaelsproul can you please take a look when you have time?
| // For distributed mode | ||
| if duties_service | ||
| .sync_duties | ||
| .selection_proof_config | ||
| .parallel_sign |
There was a problem hiding this comment.
I think we could think about re-combining these two cases in future, as the only substantial difference is the usage of FuturesUnordered in the non-distributed case. The non-distributed case is still parallel but it waits for all of the proofs to come in before writing them to the in-memory map. Whereas in the distributed case we add proofs as they become available. FuturesUnordered would likely be fine for both cases, and would save us a lot of duplication of logic.
I've opened an issue:
…sigp#7016) * sigp#6610 - [x] Add `beacon_committee_selections` endpoint - [x] Test beacon committee aggregator and confirmed working - [x] Add `sync_committee_selections` endpoint - [x] Test sync committee aggregator and confirmed working
Issue Addressed
Proposed Changes
beacon_committee_selectionsendpointsync_committee_selectionsendpointAdditional Info
Thank you @michaelsproul and @macladson for the help and guidance