-
Notifications
You must be signed in to change notification settings - Fork 971
Have nightly tests against nightly generated artifacts #7366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
321ae4d
Download and decompress minimal nightly test vectors
GaAstDev e538d76
Correct github token
GaAstDev 3b2f93b
Use mainnet test vectors
GaAstDev 94956f3
Move nightly tests to seperate folder
GaAstDev ca2e064
Add target to main Makefile
GaAstDev df74ab8
Add workflow for nightly tests
GaAstDev 910f5dc
Nightly target decompress tests over test_ef
GaAstDev a32f0ab
Have Mainnet Minimal General downloaded
GaAstDev 5820cdf
Add BLS tests
GaAstDev 06699e7
change secret in yml
GaAstDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Nightly mainnet tests | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: zsh {0} | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| ref: | ||
| description: The branch, tag or SHA to checkout and build from | ||
| default: unstable | ||
| type: string | ||
| required: true | ||
| schedule: | ||
| # Every day at 00:00 UTC | ||
| - cron: '0 0 * * *' | ||
|
|
||
| jobs: | ||
| ef-nightly-test: | ||
| name: ef-tests-ubuntu | ||
| needs: [check-labels] | ||
| if: needs.check-labels.outputs.skip_ci != 'true' | ||
| # Use self-hosted runners only on the sigp repo. | ||
| runs-on: ${{ github.repository == 'sigp/lighthouse' && fromJson('["self-hosted", "linux", "CI", "small"]') || 'ubuntu-latest' }} | ||
| env: | ||
| LIGHTHOUSE_GITHUB_TOKEN: ${{ secrets.LIGHTHOUSE_GITHUB_TOKEN }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Get latest version of stable Rust | ||
| if: env.SELF_HOSTED_RUNNERS == 'false' | ||
| uses: moonrepo/setup-rust@v1 | ||
| with: | ||
| channel: stable | ||
| cache-target: release | ||
| bins: cargo-nextest | ||
| - name: Run consensus-spec-tests with blst and fake_crypto | ||
| run: make run-ef-nightly-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to the team, but personally I think we should remove this workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtraglia Are you concerned about noisy breakages, or accidentally revealing some bug on public CI? Both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noise. Lots of the time, these tests will fail due to unimplemented spec changes. And I'm planning on aggregating the status of these in a new website (and eventually on Hive).