blanket signed root#7367
Closed
ltitanb wants to merge 1 commit intosigp:unstablefrom
ltitanb:blanket_signed_root
Closed
blanket signed root#7367ltitanb wants to merge 1 commit intosigp:unstablefrom ltitanb:blanket_signed_root
ltitanb wants to merge 1 commit intosigp:unstablefrom
ltitanb:blanket_signed_root
Conversation
|
|
This was referenced Apr 28, 2025
mergify bot
pushed a commit
that referenced
this pull request
May 12, 2025
ref: #7367 Implement `TestRandom` for a few types
michaelsproul
requested changes
May 13, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Making SignedRoot opt-in was an intentional design choice to statically prevent signing of objects that should never be signed.
At a glance, I would prefer to keep it that way. Which type did you find yourself wanting SignedRoot on that didn't have it already implemented? Could we add that implementation instead? Or could you add it downstream?
michaelsproul
added
waiting-on-author
Contributor
Author
|
Noted, will follow the same approach downstream! |
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2025
ref: #7367 Implement `From<Hash256>` for `ExecutionBlockHash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
We (Helix relay), have recently switched our consensus types to Lighthouse. During integration we made a few small quality of life changes that would be great to upstream so we can get rid of the fork. Overall all the changes are quite small and don't change any core logic.
Proposed Changes
Make a blanket implementation of
SignedRootfor all impls ofTreeHash