Skip to content

Change slog to tracing in comments #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 3 commits into from
May 6, 2025
Merged

Change slog to tracing in comments #7378

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c91e03e
Delete todo
chong-he Apr 30, 2025
f982595
Update common/logging/src/sse_logging_components.rs
chong-he May 6, 2025
8c791b7
Merge branch 'unstable' into delete-todo
macladson May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions common/logging/src/sse_logging_components.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// TODO(tracing) fix the comments below and remove reference of slog::Drain
//! This module provides an implementation of `slog::Drain` that optionally writes to a channel if
//! This module provides an implementation of `tracing_subscriber::layer::Layer` that optionally writes to a channel if
//! there are subscribers to a HTTP SSE stream.

use serde_json::json;
Expand Down
Loading