Skip to content

Comments

docs (faq.md): update 404-error link #7392

Closed
gap-editor wants to merge 2 commits intosigp:unstablefrom
gap-editor:unstable
Closed

docs (faq.md): update 404-error link #7392
gap-editor wants to merge 2 commits intosigp:unstablefrom
gap-editor:unstable

Conversation

@gap-editor
Copy link

@gap-editor gap-editor commented May 2, 2025

No description provided.

macladson
macladson reviewed May 2, 2025
View reviewed changes
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct link. A fix for the broken link already has a PR so I will close this one

@macladson macladson closed this May 2, 2025
@gap-editor
Copy link
Author

gap-editor commented May 2, 2025 •
edited
Loading

This is not the correct link. A fix for the broken link already has a PR so I will close this one

@macladson my bad, you are right. but in #7387 invalid link is on 326 line, while my is on 243. sol let me fix my mistake, please!

@macladson
Copy link
Member

macladson commented May 2, 2025

Ah you are right, I just saw the same link and assumed it was the same line, sorry about that!
I'll reopen it for now, although we might want to just combine the two PRs since they are related

@macladson macladson reopened this May 2, 2025
@macladson macladson added waiting-on-author The reviewer has suggested changes and awaits thier implementation. docs Documentation labels May 2, 2025
@gap-editor
Copy link
Author

gap-editor commented May 2, 2025

@macladson fixed link! sorry for my mistake and thank you for reopening!

@macladson
Copy link
Member

macladson commented May 2, 2025 •
edited
Loading

Ah I see why I got confused. They actually are the same line, it's just that your branch is correctly targeting unstable whereas the other PR is targeting stable which is why the line numbers are different. I'll give the original author a chance to fix their PR since they got in first but if I don't hear from them tomorrow I'll merge yours

@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 2, 2025
@macladson
Copy link
Member

macladson commented May 5, 2025

Completed in #7387

@macladson macladson closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macladson macladson macladson left review comments

Assignees

No one assigned

Labels

docs Documentation ready-for-review The code is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gap-editor @macladson