Skip to content

simulator: Fix Failed to initialize dependency logging #7393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 6 commits into from
May 30, 2025
Merged

simulator: Fix Failed to initialize dependency logging #7393

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
489c86b
Remove env_loger
ackintosh May 2, 2025
d23992d
Remove unused dependencies
ackintosh May 3, 2025
31c7abf
Merge branch 'unstable' into error-on-initializing-logger
jimmygchen May 27, 2025
3450c2f
Merge branch 'unstable' into error-on-initializing-logger
ackintosh May 29, 2025
48ba964
Add logging back now that it’s actually being used in simulations
ackintosh May 29, 2025
b387c09
Merge remote-tracking branch 'origin/error-on-initializing-logger' in…
ackintosh May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions testing/simulator/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,10 @@ edition = { workspace = true }

[dependencies]
clap = { workspace = true }
env_logger = { workspace = true }
environment = { workspace = true }
eth2_network_config = { workspace = true }
execution_layer = { workspace = true }
futures = { workspace = true }
kzg = { workspace = true }
logging = { workspace = true }
Copy link
Member

@jimmygchen jimmygchen May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ackintosh it turns out we're still using the logging crate for build_workspace_filter, I think we add this back?

node_test_rig = { path = "../node_test_rig" }
parking_lot = { workspace = true }
rayon = { workspace = true }
Expand Down
4 changes: 0 additions & 4 deletions testing/simulator/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,12 @@ mod local_network;
mod retry;

use cli::cli_app;
use env_logger::{Builder, Env};
use local_network::LocalNetwork;
use types::MinimalEthSpec;

pub type E = MinimalEthSpec;

fn main() {
// Debugging output for libp2p and external crates.
Builder::from_env(Env::default()).init();

let matches = cli_app().get_matches();
match matches.subcommand_name() {
Some("basic-sim") => match basic_sim::run_basic_sim(&matches) {
Expand Down
Loading