fix: Distinguish long chains from failed chains in block lookup sync#7584
Closed
gitToki wants to merge 5 commits intosigp:unstablefrom
Closed
fix: Distinguish long chains from failed chains in block lookup sync#7584gitToki wants to merge 5 commits intosigp:unstablefrom
gitToki wants to merge 5 commits intosigp:unstablefrom
Conversation
|
Some required checks have failed. Could you please take a look @gitToki? 🙏 |
Collaborator
|
Hey @gitToki thanks for the contribution! But we are in the process of changing the syncing algorithm. The new version won't need to distinguish long chains since those will always be synced, see |
Contributor
Author
|
Oh okay, I will close this PR then if it's no longer relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
ticket
Proposed Changes
When a chain reaches PARENT_DEPTH_TOLERANCE, the code was putting it in failed_chains and penalizing peers who reference blocks from that chain, even if the chain itself was valid
Changes: