-
Notifications
You must be signed in to change notification settings - Fork 971
Add a guide to partially reconstruct historic states to Lighthouse book #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
10d3591
delete homebrew note
chong-he 42fcb3a
database schema update
chong-he 90a422a
Add partial state history faq
chong-he 9cf0cad
revise
chong-he 0674ac6
spelling
chong-he a2a9950
update database schema version
chong-he 7cbf7f1
update default gas limit
chong-he 2321342
Merge branch 'unstable' into book-faq
chong-he 9c6327c
Some formatting & tweaks
michaelsproul 8076ca7
update apple aarch
chong-he File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,6 +75,7 @@ Proto | |
| PRs | ||
| Prysm | ||
| QUIC | ||
| QuickNode | ||
| RasPi | ||
| README | ||
| RESTful | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I'm understanding correctly, the flag
--reconstruct-historic-statesis only necessary here to "trick" the database into thinking it is going to perform state reconstruction and so doesn't prune states? Otherwise this is just effectively checkpoint syncing to an older state and then syncing forwards as normal (minus state pruning). Does that mean that over time you'd have to repeat these steps to control state db growth?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, once you sync like this your node keeps all states newer than the checkpoint. In practice it shouldn't be too bad, because state diffs are magic, but I guess users doing this are really interested in saving space. We could add a note along these lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If state pruning is already disabled with the flag
--reconstruct-historic-states, how to prune states again? Is it done via the manual pruning steps?So if saving space is a goal, then have to kind of do the manual state pruning from time to time? Because once
--reconstruct-historic-stateis used, automatic state pruning will not be active for the database from my understandingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I added some text at the end here which just says to repeat the process
9c6327c