Make notifier_service::notify pub#7708
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Jul 7, 2025
Merged
Conversation
dknopik
changed the title
notifier_service::notify pubnotifier_service::notify pub
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Jul 10, 2025
Anchor wants the `notify` function to run only in certain cases - so the `spawn_notifier` function is unsuitable for us. Anchor uses it's own `notify` function, which then calls `notifier_service::notify` (in most circumstances). To enable that, `notify` needs to be `pub`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Anchor wants the
notifyfunction to run only in certain cases - so thespawn_notifierfunction is unsuitable for us.Proposed Changes
Anchor uses it's own
notifyfunction, which then callsnotifier_service::notify(in most circumstances). To enable that,notifyneeds to bepub.