Remove tracing instrumentation#7765
Closed
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Closed
Conversation
michaelsproul
commented
Jul 21, 2025
Comment on lines
-820
to
-824
| .instrument(tracing::info_span!( | ||
| "", | ||
| service = "fetch_engine_blobs", | ||
| block_root = format!("{:?}", block_root) | ||
| )) |
Member
Author
There was a problem hiding this comment.
This one kind of looks like it was added recently. Maybe you want to keep this @jimmygchen?
michaelsproul
commented
Jul 21, 2025
Comment on lines
-616
to
-619
| .instrument(info_span!( | ||
| "DataAvailabilityChecker", | ||
| service = "data_availability_checker" | ||
| )) |
Member
Author
There was a problem hiding this comment.
This one looks pretty sus
Member
Author
|
Closing for now as this had no impact on OOMs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Completely remove all
instrumentcalls. This might be overkill, but I'm taking the maximally conservative approach while we debug OOMs on Fusaka devnets.