Update Rust Edition to 2024#7766
Conversation
Co-authored-by: Mac L <mjladson@pm.me>
|
It looks like Rust 1.89 is in effect and is already linting the chain I revised all in this single commit: 8665e63, unfortunately this makes the diff and files changed increased by a lot |
|
This pull request has merge conflicts. Could you please resolve them @chong-he? 🙏 |
|
I think we should merge this ASAP and include it in @macladson you probably have the best ability to review quickly as you can review just the diff since your last review. @chong-he there is a single conflict now which would be good to fix so we can merge immediately once Mac gives the 👍 |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. |
Thank you so much for your detailed review! |
|
Woohoo! Thanks Mac for the review and CK for the impl! ❤️ |
Issue Addressed
Thanks @dknopik and @michaelsproul for your help!