Fix leak in range sync components_by_range_requests#7767
Closed
jimmygchen wants to merge 4 commits intosigp:unstablefrom
Closed
Fix leak in range sync components_by_range_requests#7767jimmygchen wants to merge 4 commits intosigp:unstablefrom
components_by_range_requests#7767jimmygchen wants to merge 4 commits intosigp:unstablefrom
Conversation
jimmygchen
commented
Jul 21, 2025
| }); | ||
| } | ||
| // FIXME: hack to remove range request before a retry | ||
| network.remove_range_request_by_id(request_id); |
Member
Author
There was a problem hiding this comment.
Note that this hack didn't fix it
The metric i was looking at is sync_active_network_requests, type == components_by_range, recorded here:
lighthouse/beacon_node/network/src/sync/network_context.rs
Lines 1705 to 1708 in 790c94c
This change what caused entries not to be removed i believe, its used by both range and backfill:
lighthouse/beacon_node/network/src/sync/network_context.rs
Lines 745 to 751 in 790c94c
Member
Author
|
This will be fixed properly by @pawanjay176 in #7762. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
When a data column range sync fails with coupling error returned below, if the coupling error does not contain a column and peer (i.e.
column_and_peer == None)lighthouse/beacon_node/network/src/sync/block_sidecar_coupling.rs
Lines 286 to 292 in 9181ff4
The entire batch gets retried, without the previous
context.components_by_range_requestsentry being removed, this result in unbounded memory usage increase as shown in the metric:Note: this PR is not tested and I'm not sure if the fix is good - but just wanted to illustrate the issue.