Skip to content

Comments

use DEFAULT_TARGET_PEERS for target peers everywhere#7916

Merged
mergify[bot] merged 1 commit intosigp:unstablefrom
jxs:use-default-target-peers-const
Aug 22, 2025
Merged

use DEFAULT_TARGET_PEERS for target peers everywhere#7916
mergify[bot] merged 1 commit intosigp:unstablefrom
jxs:use-default-target-peers-const

Conversation

@jxs
Copy link
Member

@jxs jxs commented Aug 21, 2025

Issue Addressed

Was going to leave this as a comment on #7877 but when noticed it had already been merged.
we have DEFAULT_TARGET_PEERS which was set to 50 and only used on the Default impl for peer_manager's Config, which then get's overridden by this lighthouse_network::Configs default
This PR unifies everything on DEFAULT_TARGET_PEERS

@jxs jxs requested a review from AgeManning August 21, 2025 16:00
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @jxs

@jimmygchen jimmygchen added the ready-for-merge This PR is ready to merge. label Aug 21, 2025
mergify bot added a commit that referenced this pull request Aug 21, 2025
mergify bot added a commit that referenced this pull request Aug 21, 2025
@mergify mergify bot merged commit 884f300 into sigp:unstable Aug 22, 2025
54 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants