Skip to content

Fix incorrect prune test logic #7999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Sep 4, 2025
Merged

Fix incorrect prune test logic #7999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions beacon_node/lighthouse_network/src/peer_manager/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2885,11 +2885,10 @@ mod tests {
*peer_manager.network_globals.sampling_subnets.write() = HashSet::new();

// Create 12 peers:
// - 4 on custody subnet 0
// - 3 on subnet 1
//- 2 on subnet 2
// - 3 scattered.
// Every 4th peer (0,4,8) is on sync committee 0.
// * 4 on custody subnet 0, all on sync committee 0 subnet as well (should only prune up to 2 peers)
// * 3 on subnet 1
// * 2 on subnet 2
// * 3 scattered.
let mut peers = Vec::new();
for i in 0..12 {
let peer = PeerId::random();
Expand All @@ -2901,7 +2900,7 @@ mod tests {
7..9 => 2,
_ => i - 6,
};
let on_sync_committee = i % 4 == 0;
let on_sync_committee = i < 4;

{
let mut peers_db = peer_manager.network_globals.peers.write();
Expand Down Expand Up @@ -2949,10 +2948,10 @@ mod tests {
.cloned()
.collect();

let sync_committee_peers = [&peers[0], &peers[4], &peers[8]];
// only 2 peers should be pruned from the 4 peers in subnet 0.
let remaining_sync_peers = connected_peers
.iter()
.filter(|peer| sync_committee_peers.contains(peer))
.filter(|peer| peers[0..4].contains(peer))
.count();
assert_eq!(
remaining_sync_peers, 2,
Expand Down
Loading