[WIP] Cell Dissemination (Partial messages)#8314
Draft
dknopik wants to merge 107 commits intosigp:unstablefrom
Draft
[WIP] Cell Dissemination (Partial messages)#8314dknopik wants to merge 107 commits intosigp:unstablefrom
dknopik wants to merge 107 commits intosigp:unstablefrom
Conversation
5502e14 to
096fb78
Compare
…useless republishs
This enables - last metric - correct handling of full column
no special case for duplicates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Additional Info
TODO(dknopik)DasColumn, which abstracts over full and partial columns. It can not be implemented over the actual partial message, as much data is missing, thereforeVerifiablePartialDataColumnexists. This turned out not very nice. Currently, I believe a better approach would be a new container for block cell data, which is used throughout the codebase and converted into full or partial messages as need.Arcsituation has gone out of hand and in conjunction with theDasColumntrait has become very unergonomic and at times inefficient. I believe some of them should be removed, and only at the lowest levelArcshould be used to avoid double or triple arcing. E.g. at committment level, or even cell level.Rough type glossary, will be turned into more detailed doc comments if this approach stays:
PartialDataColumnSidecar: The actual message being sentDanglingPartialDataColumn: The message along any information we receive through the partial message protocol: column index and block rootPartialDataColumnSidecarMessage: a partial data column along with optional info for eager sendingVerifiablePartialDataColumn: a partial data column along with all info needed for KZG/gossip verificationTesting status: