Enforce stricter checks on certain constants#8500
Merged
mergify[bot] merged 3 commits intosigp:unstablefrom Feb 23, 2026
Merged
Enforce stricter checks on certain constants#8500mergify[bot] merged 3 commits intosigp:unstablefrom
mergify[bot] merged 3 commits intosigp:unstablefrom
Conversation
jimmygchen
approved these changes
Feb 20, 2026
Member
jimmygchen
left a comment
There was a problem hiding this comment.
This is a valid cleanup, however note that changing > to >= reduces the effective runtime limits by 1 (e.g., batch buffers go from 6 to 5, retries from 4 to 3). Impact should be negligible but it is a subtle change in production behavior, not just a cleanup.
Member
|
@mergify queue |
Merge Queue Status🛑 Queue command has been cancelled |
Merge Queue StatusRule:
This pull request spent 33 minutes 12 seconds in the queue, including 30 minutes 5 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Which issue # does this PR address?
None
Proposed Changes
All of these are performing a check, and adding a batch, or creating a new lookup, or a new query, etc..
Hence all of these limits would be off by one.
Example:
Without the
>being changed to a>=, we would allow 6. The same idea applies to all changes proposed.Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.