Progressive data structures and tests EIP-7916, EIP-8016#8505
Open
michaelsproul wants to merge 12 commits intounstablefrom
Open
Progressive data structures and tests EIP-7916, EIP-8016#8505michaelsproul wants to merge 12 commits intounstablefrom
michaelsproul wants to merge 12 commits intounstablefrom
Conversation
michaelsproul
added
spec_change
Member
Author
|
I've made a bunch of progress on this, but it requires local checkouts of
Progressive bitlist tests are currently not passing, need to dig into why. The derive macro for progressive containers with 1 field works though 😅 |
michaelsproul
commented
Jan 12, 2026
Comment on lines
+389
to
+397
| #[derive(Debug, Clone, PartialEq, Decode, Encode, TreeHash, Deserialize)] | ||
| #[tree_hash( | ||
| struct_behaviour = "progressive_container", | ||
| active_fields(0, 0, 0, 0, 1) | ||
| )] | ||
| #[context_deserialize(ForkName)] | ||
| struct ProgressiveSingleListContainerTestStruct { | ||
| C: ProgressiveBitList, | ||
| } |
Member
Author
There was a problem hiding this comment.
Looking for feedback on the UX of this.
I quite like this UX for progressive containers because it closely follows the spec. We can just copy the active_fields vec straight into the struct attributes.
michaelsproul
commented
Jan 12, 2026
michaelsproul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Run the EF tests for new types from EIP-7916 and EIP-8016:
ProgressiveListProgressiveBitListThe SSZ generic tests are passing if you run them without compiling the rest of Lighthouse:
Everything else is probably broken.
Additional Info
Depends on:
Known Issues
BitList<Progressive>::with_capacityhas created some type inference ambiguities causingstate_processingnot to compile. We should probably rename this method inethereum_ssz.unstablesince the types refactor nor the gloas-containers merge.