Gloas attestation verification #8705
Merged
mergify[bot] merged 4 commits intosigp:unstablefrom Feb 13, 2026
Merged
Conversation
Member
Author
|
@jimmygchen sorry i just realized you may have been assigned to this. accidentally jumped the gun here, my bad |
dapplion
reviewed
Feb 10, 2026
| /// This test only runs when `FORK_NAME=gloas` is set with `fork_from_env` feature. | ||
| // TODO(EIP-7732): Enable this test once gloas block production works in test harness. | ||
| // `state.latest_execution_payload_header()` not available in Gloas. | ||
| #[ignore] |
Collaborator
There was a problem hiding this comment.
Strange to merge ignored tests
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
eserilev
added
ready-for-review
dapplion
approved these changes
Feb 13, 2026
Collaborator
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
Gossip logic aligns with the spec, let's review the tests they are enabled
pawanjay176
added
ready-for-merge
Merge Queue StatusRule:
This pull request spent 31 minutes 23 seconds in the queue, including 29 minutes 2 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
https://github.com/ethereum/consensus-specs/blob/master/specs/gloas/p2p-interface.md#attestation-subnets
Implements attestation verification logic for Gloas and adds a few gloas related tests. Note that a few of these tests rely on gloas test harness block production which hasn't been built out yet. So for now those tests are ignored.