Correctly compute process times during ProcessHealth::observe#8793
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Feb 14, 2026
Merged
Correctly compute process times during ProcessHealth::observe#8793mergify[bot] merged 2 commits intosigp:unstablefrom
ProcessHealth::observe#8793mergify[bot] merged 2 commits intosigp:unstablefrom
Conversation
macladson
added
ready-for-review
dapplion
approved these changes
Feb 13, 2026
Collaborator
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
Nice catch! Looks good to me
macladson
added
ready-for-merge
Merge Queue StatusRule:
This pull request spent 31 minutes in the queue, including 28 minutes 48 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I believe I found a bug where during computation of
pid_process_seconds_totalwe addchildren_systemtwice.Proposed Changes
I assume that it was originally intended to add
children_systemandchildren_useronce each