merge queue: embarking unstable (c59e4a0) and #8592 together#8812
Closed
mergify[bot] wants to merge 51 commits intounstablefrom
Closed
merge queue: embarking unstable (c59e4a0) and #8592 together#8812mergify[bot] wants to merge 51 commits intounstablefrom
mergify[bot] wants to merge 51 commits intounstablefrom
Conversation
- Fix logic error: add missing `!` in attestation signing conditions - Fix typos: Substract -> Subtract, UknownDataColumnParent -> UnknownDataColumnParent - Rename reset_metrics to capture_metrics_baseline - Rename max_seen_peers to seen_peers - Use with_ prefix for builder methods (with_process_result, with_block_imported_while_processing) - Add documentation to simulate fn and CompleteStrategy
# Conflicts: # beacon_node/network/src/sync/tests/lookups.rs # beacon_node/network/src/sync/tests/mod.rs # beacon_node/network/src/sync/tests/range.rs
Update lookups.rs and range.rs to work with the new RpcBlock enum (FullyAvailable | BlockOnly) from PR #8424. Replace removed methods (.blobs(), .custody_columns(), new_without_blobs, new_with_custody_columns) with the new block_data() + AvailableBlockData API. Also adapt to superstruct-generated getters on DataColumnSidecar (Fulu/Gloas variants).
Reproduces the race condition from PR #3677 where block 1 gets imported via gossip right before the lookup processes it. The test verifies that when the oldest block in a parent lookup chain returns DuplicateFullyImported, the remaining blocks (2 and 3) still process successfully.
… threading, cfg(test) metrics
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch unstable (c59e4a0) and #8592 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #8592.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:check-success=local-testnet-successcheck-success=test-suite-successRequired conditions to stay in the queue:
#approved-reviews-by >= 1check-success=license/clacheck-success=target-branch-checklabel!=do-not-merge