Fix eth2 compilation by feature gating SseEventSource#8819
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom Feb 16, 2026
Merged
Fix eth2 compilation by feature gating SseEventSource#8819mergify[bot] merged 1 commit intosigp:unstablefrom
SseEventSource#8819mergify[bot] merged 1 commit intosigp:unstablefrom
Conversation
michaelsproul
approved these changes
Feb 16, 2026
Member
michaelsproul
left a comment
There was a problem hiding this comment.
Looks good, confirmed locally that this compiles without the feature flag.
But I agree we need to test these less-used features on CI if we want to support them. Doing this without bloating CI runtimes proportional to the number of features might prove tricky.
Merge Queue StatusRule:
This pull request spent 29 minutes 33 seconds in the queue, including 27 minutes 31 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
eth2is currently unable to be built without theeventsfeature.Proposed Changes
Feature gates the
SseEventSourcematch arm in thestatusfunction.Additional Info
We could consider adding some build checks to CI for
eth2andtypesand each feature combination to avoid this in the future.