Skip to content

Comments

Fix eth2 compilation by feature gating SseEventSource#8819

Merged
mergify[bot] merged 1 commit intosigp:unstablefrom
macladson:eth2-compilation-fix
Feb 16, 2026
Merged

Fix eth2 compilation by feature gating SseEventSource#8819
mergify[bot] merged 1 commit intosigp:unstablefrom
macladson:eth2-compilation-fix

Conversation

@macladson
Copy link
Member

Issue Addressed

eth2 is currently unable to be built without the events feature.

Proposed Changes

Feature gates the SseEventSource match arm in the status function.

Additional Info

We could consider adding some build checks to CI for eth2 and types and each feature combination to avoid this in the future.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, confirmed locally that this compiles without the feature flag.

But I agree we need to test these less-used features on CI if we want to support them. Doing this without bloating CI runtimes proportional to the number of features might prove tricky.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. infra-ci HTTP-API and removed infra-ci labels Feb 16, 2026
@mergify mergify bot added the queued label Feb 16, 2026
@mergify
Copy link

mergify bot commented Feb 16, 2026

Merge Queue Status

Rule: default


This pull request spent 29 minutes 33 seconds in the queue, including 27 minutes 31 seconds running CI.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Feb 16, 2026
@mergify mergify bot merged commit fcfd061 into sigp:unstable Feb 16, 2026
36 checks passed
@mergify mergify bot removed the queued label Feb 16, 2026
@macladson macladson deleted the eth2-compilation-fix branch February 16, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP-API ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants