Skip to content

Comments

Return correct variant for snappy errors#8841

Merged
mergify[bot] merged 1 commit intosigp:release-v8.1from
pawanjay176:rpc-error
Feb 18, 2026
Merged

Return correct variant for snappy errors#8841
mergify[bot] merged 1 commit intosigp:release-v8.1from
pawanjay176:rpc-error

Conversation

@pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Handle snappy crate errors as InvalidData instead of IoError.

@pawanjay176 pawanjay176 requested a review from jxs as a code owner February 18, 2026 00:25
@pawanjay176 pawanjay176 added ready-for-review The code is ready for review Networking labels Feb 18, 2026
@michaelsproul michaelsproul added the v8.1.1 Hotfix for v8.1.0 label Feb 18, 2026
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen changed the base branch from unstable to release-v8.1 February 18, 2026 02:32
@jimmygchen
Copy link
Member

I've changed the base branch to release-v8.1

@jimmygchen
Copy link
Member

oops looks like the branch contains unstable changes, will fix now

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 18, 2026
@mergify mergify bot added the queued label Feb 18, 2026
@mergify
Copy link

mergify bot commented Feb 18, 2026

Merge Queue Status

Rule: default


This pull request spent 36 minutes 18 seconds in the queue, including 31 minutes 14 seconds running CI.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Feb 18, 2026
mergify bot added a commit that referenced this pull request Feb 18, 2026
@mergify mergify bot merged commit c5b4580 into sigp:release-v8.1 Feb 18, 2026
36 checks passed
@mergify mergify bot removed the queued label Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Networking ready-for-merge This PR is ready to merge. v8.1.1 Hotfix for v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants