Skip to content

merge queue: embarking unstable (da141a8) and #8845 together#8857

Closed
mergify[bot] wants to merge 5 commits intounstablefrom
mergify/merge-queue/83cb988697
Closed

merge queue: embarking unstable (da141a8) and #8845 together#8857
mergify[bot] wants to merge 5 commits intounstablefrom
mergify/merge-queue/83cb988697

Conversation

@mergify
Copy link

@mergify mergify bot commented Feb 18, 2026

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch unstable (da141a8) and #8845 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #8845.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

  • check-success=local-testnet-success
  • check-success=test-suite-success

Required conditions to stay in the queue:

---
checking_base_sha: da141a8c49656534c76464663bf0f490bd7004db
previous_failed_batches: []
pull_requests:
  - number: 8845
...

jimmygchen and others added 5 commits February 18, 2026 02:17
Add Large PR Strategy section and lesson learned from #8842 regression.
When a collection element type changes, operations like .unique(), .dedup(),
.contains() silently change behavior. Document the pattern and review
strategy for large PRs.
Add Large PR Strategy section and lesson learned from #8842 regression.
When a collection element type changes, operations like .unique(), .dedup(),
.contains() silently change behavior. Document the pattern and review
strategy for large PRs.
…en/lighthouse into docs-review-lesson-type-changes
@cla-assistant
Copy link

cla-assistant bot commented Feb 18, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jimmygchen
❌ mergify[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link

cla-assistant bot commented Feb 18, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jimmygchen
❌ mergify[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@mergify mergify bot closed this Feb 18, 2026
@mergify mergify bot deleted the mergify/merge-queue/83cb988697 branch February 18, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments