Skip to content

Process head_chains in descending order of number of peers #8859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Feb 19, 2026
+2 −1
Merged

Process head_chains in descending order of number of peers #8859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6a5e89
Sort in descending order
pawanjay176 Feb 18, 2026
79e8e34
fmt
pawanjay176 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion beacon_node/network/src/sync/range_sync/chain_collection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,8 @@ impl<T: BeaconChainTypes> ChainCollection<T> {
.iter()
.map(|(id, chain)| (chain.available_peers(), !chain.is_syncing(), *id))
.collect::<Vec<_>>();
preferred_ids.sort_unstable();
// Sort in descending order
preferred_ids.sort_unstable_by(|a, b| b.cmp(a));
Copy link
Member

@michaelsproul michaelsproul Feb 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm satisfied that this works for the !chain.is_syncing() part too, as the not-syncing chains will have true, which sorts higher than false (syncing).

Copy link
Member Author

@pawanjay176 pawanjay176 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree. Based on the comment, I think the intention was always to construct preferred_ids such that the descending sort works, but we sorted ascending by mistake.


let mut syncing_chains = SmallVec::<[Id; PARALLEL_HEAD_CHAINS]>::new();
for (_, _, id) in preferred_ids {
Expand Down