Skip to content

Remove psutil and compute metrics from procfs #8865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macladson wants to merge 3 commits into
base: unstable
Choose a base branch
from
+517 −64
Open

Remove psutil and compute metrics from procfs #8865

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
024b416
Remove psutil and compute metrics from procfs
macladson Feb 19, 2026
e9497b1
Increase disk io ops tolerance
macladson Feb 19, 2026
7fcb6bc
Merge branch 'unstable' into remove-psutil
macladson Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions common/health_metrics/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@ eth2 = { workspace = true, features = ["lighthouse"] }
metrics = { workspace = true }

[target.'cfg(target_os = "linux")'.dependencies]
nix = { version = "0.26", default-features = false, features = ["fs"] }
Copy link
Member Author

@macladson macladson Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We deliberately use an outdated version of nix to avoid a duplicate dependency. Once our dependencies update their version of nix, we can bump this too

procfs = { version = "0.18", default-features = false }

[target.'cfg(target_os = "linux")'.dev-dependencies]
psutil = "3.3.0"
Copy link
Collaborator

@dapplion dapplion Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this PR is not removing psutil?

Copy link
Member Author

@macladson macladson Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we remove the consistency tests we can remove it. Also, even if we kept the tests it is now just a dev-dependency so it will never be compiled in any release build

Loading