Skip to content

Comments

Bump sqlite deps to remove hashlink 0.8#8866

Merged
mergify[bot] merged 2 commits intosigp:unstablefrom
macladson:bump-sqlite-deps
Feb 19, 2026
Merged

Bump sqlite deps to remove hashlink 0.8#8866
mergify[bot] merged 2 commits intosigp:unstablefrom
macladson:bump-sqlite-deps

Conversation

@macladson
Copy link
Member

Issue Addressed

#8547

Proposed Changes

Bump the following crates to remove hashlink 0.8:

  • rusqlite
  • r2d2-sqlite
  • yaml-rust2

Additional Info

Once we get new releases from libp2p and discv5 we will unify on hashlink 0.11, which will also remove hashlink 0.9 and 0.10

@macladson macladson added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Feb 19, 2026
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does libp2p/discv5 upstream already have the required hashlink dependency or do we need to update them as well?

@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 19, 2026
@mergify mergify bot added the queued label Feb 19, 2026
@mergify
Copy link

mergify bot commented Feb 19, 2026

Merge Queue Status

Rule: default


This pull request spent 31 minutes 47 seconds in the queue, including 29 minutes 23 seconds running CI.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Feb 19, 2026
@mergify mergify bot merged commit 2d91009 into sigp:unstable Feb 19, 2026
36 checks passed
@mergify mergify bot removed the queued label Feb 19, 2026
@macladson macladson deleted the bump-sqlite-deps branch February 20, 2026 06:11
@macladson
Copy link
Member Author

macladson commented Feb 20, 2026

Looks good. Does libp2p/discv5 upstream already have the required hashlink dependency or do we need to update them as well?

They have both been bumped on main already, so we are just awaiting a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants