Add getBlobsV1 and getBlobsV2 support to mock EL server#8870
Open
jimmygchen wants to merge 3 commits intosigp:unstablefrom
Open
Add getBlobsV1 and getBlobsV2 support to mock EL server#8870jimmygchen wants to merge 3 commits intosigp:unstablefrom
jimmygchen wants to merge 3 commits intosigp:unstablefrom
Conversation
jimmygchen
added
test improvement
dapplion
reviewed
Feb 20, 2026
| } | ||
| } | ||
|
|
||
| Ok(serde_json::to_value(blobs_and_proofs).unwrap()) |
Collaborator
There was a problem hiding this comment.
Should this return Vec<Option<...>>? To set the missing blobs to null
Member
Author
There was a problem hiding this comment.
Good catch — fixed in the latest push. V1 now returns Vec<Option<BlobAndProofV1>> with nulls at positions of missing hashes, and V2 returns Option<Vec<BlobAndProofV2>> (null if any blob is missing), per the execution-apis spec.
pawanjay176
reviewed
Feb 20, 2026
| .find(|(_, commitment)| { | ||
| &kzg_commitment_to_versioned_hash(commitment) == versioned_hash | ||
| })?; | ||
| let is_fulu_bundle = blobs_bundle.blobs.len() < blobs_bundle.proofs.len(); |
Member
There was a problem hiding this comment.
can we not decide this based on the slot? Seems like a non-obvious condition.
Maybe add a comment explaining this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revive #7986 which was approved but closed after
network-testsflaked repeatedly in the merge queue.Adds
engine_getBlobsV1andengine_getBlobsV2handlers to the mock EL server. When blobs have been generated during payload building (integration tests), they're returned by matching versioned hashes from the existingblobs_bundles. When no blobs exist (lcli paired with a real CL), empty results are returned — preventing the CL from logging "method not supported" errors.Changes from #7986:
.to_vec().into()→.to_vec().try_into().ok()?for V2 cell proofs (VariableListno longer implementsFrom<Vec<_>>)Vec<Option<BlobAndProofV1>>(per-element nullable, positionally matching the request), V2 returnsOption<Vec<BlobAndProofV2>>(all-or-nothing,nullif any blob is missing)