Remove unreachable void pattern for ConnectionLimits#8871
Merged
mergify[bot] merged 1 commit intosigp:unstablefrom Feb 20, 2026
Merged
Remove unreachable void pattern for ConnectionLimits#8871mergify[bot] merged 1 commit intosigp:unstablefrom
mergify[bot] merged 1 commit intosigp:unstablefrom
Conversation
jimmygchen
added
ready-for-review
michaelsproul
added
ready-for-merge
Merge Queue StatusRule:
This pull request spent 30 minutes 26 seconds in the queue, including 28 minutes 31 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
#[allow(unreachable_patterns)]and unreachableBehaviourEvent::ConnectionLimitsmatch arm. The MSRV is well above 1.82, so the compiler natively recognises thatConnectionLimitsevents are uninhabited (Infallible).Closes #6356