Skip to content

Comments

Add unit tests for BatchInfo and fix doc comments#8873

Merged
mergify[bot] merged 3 commits intosigp:unstablefrom
jimmygchen:test-batch-state-machine
Feb 24, 2026
Merged

Add unit tests for BatchInfo and fix doc comments#8873
mergify[bot] merged 3 commits intosigp:unstablefrom
jimmygchen:test-batch-state-machine

Conversation

@jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Feb 20, 2026 •
edited
Loading

Adds unit tests for the BatchInfo state machine in batch.rs and fixes misleading doc comments.

@jimmygchen jimmygchen changed the title Add unit tests for BatchInfo and fix misleading doc comments Add unit tests for BatchInfo and fix outdated doc comments Feb 20, 2026
@jimmygchen jimmygchen changed the title Add unit tests for BatchInfo and fix outdated doc comments Add unit tests for BatchInfo and fix doc comments Feb 20, 2026
@jimmygchen jimmygchen force-pushed the test-batch-state-machine branch from cfad078 to bc9e29c Compare February 20, 2026 05:02
@jimmygchen jimmygchen added the test improvement Improve tests label Feb 20, 2026
@jimmygchen jimmygchen force-pushed the test-batch-state-machine branch from 0e4df30 to fb5bb4b Compare February 20, 2026 06:05
@jimmygchen jimmygchen marked this pull request as ready for review February 20, 2026 06:43
@jimmygchen jimmygchen requested a review from jxs as a code owner February 20, 2026 06:43
@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Feb 20, 2026
@mergify
Copy link

mergify bot commented Feb 20, 2026

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review and removed ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 20, 2026
eserilev
eserilev approved these changes Feb 22, 2026
View reviewed changes
Copy link
Member

@eserilev eserilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 23, 2026
@mergify mergify bot added the queued label Feb 23, 2026
@mergify
Copy link

mergify bot commented Feb 23, 2026 •
edited
Loading

Merge Queue Status

Rule: default

This pull request spent 30 minutes 55 seconds in the queue, including 29 minutes 1 second running CI.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Feb 23, 2026
@mergify
Merge of #8873
1012705
@mergify mergify bot mentioned this pull request Feb 23, 2026
Closed
6 tasks
@mergify mergify bot merged commit 341682e into sigp:unstable Feb 24, 2026
45 of 46 checks passed
@mergify mergify bot removed the queued label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eserilev eserilev eserilev approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees

No one assigned

Labels

ready-for-merge This PR is ready to merge. test improvement Improve tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmygchen @eserilev