Skip to content

Comments

Bump uuid to remove duplicate#8874

Merged
mergify[bot] merged 3 commits intosigp:unstablefrom
macladson:bump-uuid
Feb 21, 2026
Merged

Bump uuid to remove duplicate#8874
mergify[bot] merged 3 commits intosigp:unstablefrom
macladson:bump-uuid

Conversation

@macladson
Copy link
Member

Issue Addressed

#8547

Proposed Changes

Bump the version of uuid in our Cargo.toml to version 1 which removes uuid 0.8 and unifies it across the workspace to version 1.19.0.

Additional Info

While this version of uuid isn't the latest, newer versions of uuid have bumped getrandom which would duplicate it for our workspace.

@macladson macladson added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Feb 20, 2026
@michaelsproul
Copy link
Member

Could deny multiple versions in the deny.toml

@macladson
Copy link
Member Author

Could deny multiple versions in the deny.toml

Ah yeah, I wasn't sure how to categorize it since it doesn't fit our usual "takes a long time to compile" criteria, but I think we can add a general "dependency hygiene" category for cases like this. Its also nice that it implies it is reasonable to remove the deny if there's a compelling reason.

@michaelsproul
Copy link
Member

Yeah I think that's good. Now cargo dent can flag the regression for us and we'll at least be made to consciously accept uuid duplication

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 21, 2026
@mergify mergify bot added the queued label Feb 21, 2026
@mergify
Copy link

mergify bot commented Feb 21, 2026

Merge Queue Status

Rule: default


This pull request spent 31 minutes 44 seconds in the queue, including 29 minutes 51 seconds running CI.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify bot added a commit that referenced this pull request Feb 21, 2026
@mergify mergify bot merged commit 9452d51 into sigp:unstable Feb 21, 2026
36 checks passed
@mergify mergify bot removed the queued label Feb 21, 2026
@macladson macladson deleted the bump-uuid branch February 22, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants