Fork aware Attestation ssz decoding#8881
Open
hopinheimer wants to merge 3 commits intosigp:unstablefrom
Open
Conversation
michaelsproul
requested changes
Feb 21, 2026
| } | ||
| } | ||
|
|
||
| pub fn from_ssz_bytes_for_fork( |
Member
There was a problem hiding this comment.
To fix the bug that was reported we probably also need to use this func in the network layer.
| } | ||
|
|
||
| /* | ||
| impl<'de, E: EthSpec> ContextDeserialize<'de, ForkName> for Vec<Attestation<E>> { |
Member
There was a problem hiding this comment.
This commented out code could be revived or deleted as part of this PR too.
michaelsproul
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
@pk910 mentioned that we are not decoding based on the current fork and defaulting to latest fork. This is a nice to have change for testing purposes