Implement TreeHash for bitfield#18
Merged
michaelsproul merged 4 commits intosigp:mainfrom Dec 20, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 79.66% 79.67% +0.01%
==========================================
Files 6 6
Lines 295 310 +15
==========================================
+ Hits 235 247 +12
- Misses 60 63 +3 ☔ View full report in Codecov by Sentry. |
macladson
commented
Jul 26, 2024
Member
|
New release is out for |
9109272 to
51b88a8
Compare
Member
|
I could use this one for sigp/lighthouse#6609, any chance we can get it merged? 🙏 My understanding is that @macladson needs to add a tree-hash test to satisfy teh bot. |
Member
|
The bot isn't meant to block the merge due to this config: We can just ignore it for now |
Member
|
I'll add a test anyway, seeing as 0% coverage looks terrible. |
michaelsproul
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for EIP-7495, bitfield has been moved to https://github.com/sigp/ethereum_ssz.
This PR implements
TreeHashfor bothBitVectorandBitListfor those types.Requires sigp/ethereum_ssz#25