Skip to content

chore: make oci11 referrer selection deterministic#4656

Open
1seal wants to merge 4 commits intosigstore:mainfrom
1seal:fix/deterministic-oci11-referrer-selection
Open

chore: make oci11 referrer selection deterministic#4656
1seal wants to merge 4 commits intosigstore:mainfrom
1seal:fix/deterministic-oci11-referrer-selection

Conversation

@1seal
Copy link
Contributor

@1seal 1seal commented Jan 20, 2026

  • make oci 1.1 referrer selection deterministic by sorting descriptors by digest before selecting the last result
  • add unit tests to ensure selection is order-independent and does not mutate inputs
  • note: this does not define the “correct” semantics for multiple matching referrers; please advise whether cosign should fail closed, verify all, or prefer a specific key (e.g. validated annotations)

refs #4655

Signed-off-by: 1seal <security@1seal.org>
@1seal 1seal requested a review from a team as a code owner January 20, 2026 23:32
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.16%. Comparing base (2ef6022) to head (5298c78).
⚠️ Report is 638 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4656      +/-   ##
==========================================
- Coverage   40.10%   36.16%   -3.94%     
==========================================
  Files         155      220      +65     
  Lines       10044    12431    +2387     
==========================================
+ Hits         4028     4496     +468     
- Misses       5530     7241    +1711     
- Partials      486      694     +208     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

1seal added 3 commits January 21, 2026 00:00
Signed-off-by: 1seal <security@1seal.org>
Signed-off-by: 1seal <security@1seal.org>
Signed-off-by: 1seal <security@1seal.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant