docs(crd): clarify ctlog:{} disables tlog verification#1923
Open
1seal wants to merge 1 commit intosigstore:mainfrom
Open
docs(crd): clarify ctlog:{} disables tlog verification#19231seal wants to merge 1 commit intosigstore:mainfrom
1seal wants to merge 1 commit intosigstore:mainfrom
Conversation
Signed-off-by: konkoleg <konko.oleg@gmail.com>
1seal
force-pushed
the
docs/ctlog-empty-disables-tlog
branch
from
678aa14 to
048185e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this updates the clusterimagepolicy crd/docs wording to match the intended behavior discussed in sigstore/policy-controller#
ctlog: {}(ctlog present but notrustRootRefand nourl) disables tlog verificationctlog: {}casechanges are doc-only (no behavior changes).
note: i see
go test ./...failing on currentmainlocally due to an expired tufroot.jsonin testdata; this pr doesn’t modify that.