Incorporating the bank operation reference for unique identification#287
Merged
guillaume-sainthillier merged 5 commits intosilarhi:6.xfrom Mar 17, 2025
Merged
Conversation
| use function strlen; | ||
|
|
||
| /** @internal */ | ||
| class RegexMatch |
There was a problem hiding this comment.
Why these changes in this class?
Contributor
Author
There was a problem hiding this comment.
Indeed, that change wasn't necessary. I've just rolled it back.
Member
|
Thank you for PR! Do you have any documentation piece about this part which was not documented before? |
Contributor
Author
|
The field is documented in the PDF included in the project (CFONB - Structure) under "Référence de l'opération." You can also find it here: https://www.cfonb.org/fichiers/20130612113947_7_4_Releve_de_Compte_sur_support_informatique_2004_07.pdf, on page 7 under the name "Zone référence" (non-mandatory alphanumeric type). |
Member
|
Nice catch! Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your excellent work on this project!
This PR adds support for handling the operation reference from the CFONB120 files (positions 105–120 of a type 04 line). This field corresponds to the Account Servicer Reference as defined in the ISO20022 standard.
After discussing the terminology, I opted to name the new field bankOperationReference. I found that the term "Account Servicer Reference" may be unclear for users, and "bankOperationReference" better conveys that it is the reference provided by the bank to uniquely identify the operation.
This change is essential for our reconciliation process of bank transfers, as we also process messages following the ISO20022 standard. In our scenario, the only way to uniquely identify an operation for the same bank is through this reference.
I have updated the related tests to ensure that the new field is correctly parsed and accessible.
Thank you again for the project, and I look forward to your feedback!