Add yarn lint (eslint, prettier) to CI#82
Merged
guillaume-sainthillier merged 5 commits intomainfrom Nov 5, 2025
Merged
Conversation
Member
guillaume-sainthillier
commented
Nov 5, 2025
guillaume-sainthillier
commented
- Install eslint and related dependencies (@babel/eslint-parser, eslint-plugin-react, eslint-plugin-react-hooks, eslint-config-prettier)
- Create eslint.config.js with React/JSX support
- Add lint and format scripts to package.json (eslint + prettier)
- Update .laminas-ci.json to include 'yarn lint' in Lint job
- Configure globals (fetch, window, document, etc.) for browser environment
- Install eslint and related dependencies (@babel/eslint-parser, eslint-plugin-react, eslint-plugin-react-hooks, eslint-config-prettier) - Create eslint.config.js with React/JSX support - Add lint and format scripts to package.json (eslint + prettier) - Update .laminas-ci.json to include 'yarn lint' in Lint job - Configure globals (fetch, window, document, etc.) for browser environment
- Add standalone 'lint-js' job in GitHub Actions workflow with setup-node@v4 - Run ESLint and Prettier checks independently in the new job - Remove yarn lint from laminas CI job (now handled by dedicated job) - Update lint-staged to run eslint --fix on .js/.jsx files before prettier - Separate linting for JS/JSX files (eslint + prettier) from other files
ESLint is configured with eslint-config-prettier, so running eslint --fix is sufficient for JS/JSX files. No need to run prettier separately on these files.
Yarn install requires vendor/symfony/ux-turbo/assets to be present since package.json has a file dependency on it. Install composer dependencies before yarn to ensure the Symfony UX packages are available.
guillaume-sainthillier
deleted the
claude/add-yarn-lint-ci-011CUpsWfgwf7wRSDpDQpDzA
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.